On Mon, Jun 27, 2022 at 03:48:38PM +0800, Andy Kuo wrote: > Add CONFIG_DRIVER_NL80211_SYNA for synaptics wifi Why would this be needed? The proposed changes seem to make this behave just like CONFIG_DRIVER_NL80211_BRCM=y.. > diff --git a/hostapd/android.config b/hostapd/android.config > @@ -25,11 +25,16 @@ > +# Broadcom vendor extensions to nl80211 > +ifeq ($(BOARD_WLAN_DEVICE),bcmdhd) > +CONFIG_DRIVER_NL80211_BRCM=y That part is not covered in the commit message.. > +# Synaptics vendor extensions to nl80211 > +else ifeq ($(BOARD_WLAN_DEVICE),synadhd) > +CONFIG_DRIVER_NL80211_SYNA=y > +else But as far as this one is concerned, wouldn't it be sufficient to replace all of this patch with those four lines and just set CONFIG_DRIVER_NL80211_BRCM=y instead of introducing a new duplicated build parameter for this? -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap