On Mon, Oct 11, 2021 at 01:24:30PM +0200, Tom Barthe wrote: > Support for RADIUS attributes filtering by tag > Replace some vlan_ids with vlan_descriptions > Add a per PSK vlan_description > Fix selection of Tunnel* attributes by tag > Add default_radius_vlan in sta_info > Retrieve and use a per-PSK vlan_description > Remove useless variable This set seems to break most of existing VLAN functionality. At least the following hwsim test cases fail with these patches: ap_vlan_open ap_vlan_file_open ap_vlan_file_open2 ap_vlan_wpa2 ap_vlan_wpa2_radius_local ap_vlan_tagged ap_vlan_without_station ap_open_per_sta_vif ap_vlan_open_per_sta_vif ap_vlan_reconnect I did not look at the details on what exactly was causing this, but hostapd seemed to end up assigning associating stations to VLAN-ID 0 instead of the VLAN configuration in the local files. Similarly, number of RADIUS test cases failed: radius_acct_psk radius_acct_psk_sha256 radius_acct_ft_psk radius_psk_default ap_vlan_wpa2_psk_radius_required These showed "Invalid VLAN ID 0" in hostapd debug log. In general, I'm recommending running all the hwsim test cases (see tests/hwsim/vm/README) to test against regressions. It would also be nice to see new test cases being added for any new functionality like the changes in this patchset to demonstrate how the feature works and to make sure there continues to be a good testing coverage for all the functionality and means for automatically detecting regressions (like these test case failures here demonstrate). -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
