Re: [PATCH 7/7] Remove useless variable

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 11, 2021 at 01:24:37PM +0200, Tom Barthe wrote:
> diff --git a/src/ap/ieee802_11.c b/src/ap/ieee802_11.c
> @@ -2321,12 +2321,11 @@ ieee802_11_set_radius_info(struct hostapd_data *hapd, struct sta_info *sta,
>  {
>  	u32 session_timeout = info->session_timeout;
>  	u32 acct_interim_interval = info->acct_interim_interval;
> -	struct vlan_description *vlan_id = &info->vlan_id;
>  	struct hostapd_sta_wpa_psk_short *psk = info->psk;
>  	char *identity = info->identity;
>  	char *radius_cui = info->radius_cui;
>  
> -	sta->default_radius_vlan = *vlan_id;
> +	sta->default_radius_vlan = info->vlan_id;

This looks a bit strange as a separate patch since that
sta->default_radius_vlan does not even exist before the earlier patches
in this series. Maybe this should be merged into the patch 5/7 instead.
 
-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux