On Sat, Sep 18, 2021 at 11:24:30PM -0700, Arowa Suliman wrote: > Replaced the word dummy with the inclusive word Stub. Thanks, I'll apply the other changes from patches 4/7 and 5/7 with a bit different split to a number of commits except for the following ones that cannot be changed due to the kernel build configuration and interface using the "dummy" word and as such, the changes in hostap.git would break functionality: > tests/hwsim/test_ap_vlan.py | 54 ++++++++++---------- > tests/hwsim/vm/kernel-config | 2 +- > tests/hwsim/vm/kernel-config.uml | 2 +- > diff --git a/tests/hwsim/test_ap_vlan.py b/tests/hwsim/test_ap_vlan.py > def ap_vlan_iface_test_and_prepare_environ(): > - subprocess.call(['ip', 'link', 'add', 'dummy0', 'type', 'dummy']) > - subprocess.call(['ifconfig', 'dummy0', 'up']) > + subprocess.call(['ip', 'link', 'add', 'stub0', 'type', 'stub']) > + subprocess.call(['ifconfig', 'stub0', 'up']) It is fine to rename the interface itself, but that "type dummy" parameter has to be maintained for this ip command to work. > diff --git a/tests/hwsim/vm/kernel-config b/tests/hwsim/vm/kernel-config > -CONFIG_DUMMY=y > +CONFIG_STUB=y > diff --git a/tests/hwsim/vm/kernel-config.uml b/tests/hwsim/vm/kernel-config.uml > -CONFIG_DUMMY=y > +CONFIG_STUB=y Those instances of CONFIG_DUMMY are references to the kernel build configuration and as such, cannot be changed in hostap.git. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
