On 30/11/2020 11:11, Jouni Malinen wrote: > On Tue, Jun 30, 2020 at 02:18:58PM +0200, Markus Theil wrote: >> From: Peter Oh <peter.oh@xxxxxxxxxxxxxxxxx> >> >> Note: DFS is assumed to be usable if a country code has been set >> diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c >> @@ -2356,6 +2356,8 @@ void ibss_mesh_setup_freq(struct wpa_supplicant *wpa_s, >> int chwidth, seg0, seg1; >> u32 vht_caps = 0; >> int is_24ghz; >> + int dfs_enabled = wpa_s->conf->country[0] && >> + (wpa_s->drv_flags & WPA_DRIVER_FLAGS_RADAR); > ... > > The commit message seems to imply that this is a change specifically for > mesh, but this function is used both both IBSS and mesh.. I can change the commit, to only allow DFS for mesh and not for IBSS. > Furthermore, > that WPA_DRIVER_FLAGS_RADAR was added for AP mode DFS/radar detection. > Is it clear that all drivers that support radar detection for AP mode > also support it for IBSS and mesh? > While looking at driver code which registers a DFS handler and eventually calls cfg80211_radar_event I've not found any evidence against the assumption, that radar detection should work for other modes than AP. But I cannot be 100% confident of course, as I may have overlooked something or some firmware may only supports DFS in AP mode, which I cannot rule out without firmware knowledge. _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
