Re: [PATCH V3 2/7] neighbor_db: set the co-locate bit

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 01/12/2020 23:49, Jouni Malinen wrote:
On Mon, Sep 21, 2020 at 01:50:57PM +0200, John Crispin wrote:
If the BSS is co-located, the corresponding bit needs to be set inside
bssid_info.
diff --git a/src/ap/neighbor_db.c b/src/ap/neighbor_db.c
@@ -260,6 +260,9 @@ void hostapd_neighbor_set_own_report(struct hostapd_data *hapd)
+     if (hapd->iconf->he_co_locate)
+             bssid_info |= NEI_REP_BSSID_INFO_HE_CO_LOCATED;
This is related to my points on the patch 1/7 regarding the meaning of
"co-located" and how it is set in different interfaces.. This subfield
indicates that the AP in this report is co-located with the AP sending
the element, so I'd guess this means the he_co_locate value needs to be
set consistently in all the interface configurations and that should be
noted in 1/7.


Also, he_co_locate is defined under CONFIG_IEEE80211AX (ap_config.h) while it is used without.

Thanks,

Shay.


_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux