On 02/12/2020 13:05, Jouni Malinen wrote:
On Sun, Jun 28, 2020 at 06:57:16PM +0300, Shay Bar wrote:
In case of MBSS, there is a need to be able to
control the Basic/Supported rates per BSS.
This patch adds that support.
This is whitespace damaged (at least all tabs have been converted to
spaces) and as such, does not apply. As far as the changes are
concerned, this would seem to break current behavior where the
support/basic rate sets can be set of the first BSS in hostapd.conf with
the expectation of those settings applying to all consecutively added
virtual BSSs. It would also be easier to review the changes if the
hostapd_prepare_rates() function were not moved unnecessarily to another
file in the same patch. If such cleanup is needed, that should be done
in a separate patch either before or after the main functional changes
to minimize the size of the patch that changes functionality.
Hi Jouni,
I know its changing the current behavior, but can't we assume the
basic_rates and supported_rates should be configured in the per bss
section of the hostapd.conf and if absent (as default), all rates are
allowed for this VAP? Otherwise, whats the alternative ?
The hostapd_prepare_rates() is part of this patch because it is now
preparing rates per BSS (called from hostapd_setup_bss())
Sorry for the whitespace, I will fix it after your above approval.
Thanks,
Shay
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
