Re: [PATCH] hostapd: Set Basic/Supported rates per BSS

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Jun 28, 2020 at 06:57:16PM +0300, Shay Bar wrote:
> In case of MBSS, there is a need to be able to
> control the Basic/Supported rates per BSS.
> 
> This patch adds that support.

This is whitespace damaged (at least all tabs have been converted to
spaces) and as such, does not apply. As far as the changes are
concerned, this would seem to break current behavior where the
support/basic rate sets can be set of the first BSS in hostapd.conf with
the expectation of those settings applying to all consecutively added
virtual BSSs. It would also be easier to review the changes if the
hostapd_prepare_rates() function were not moved unnecessarily to another
file in the same patch. If such cleanup is needed, that should be done
in a separate patch either before or after the main functional changes
to minimize the size of the patch that changes functionality.

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux