On 18.06.20 07:11, Shay Bar wrote: >> Thinking about it, channel switch announcement IE can also be added in kernel the same way. >> Hostapd will be informed once channel switch is done (counter reached 0) so it will update the new channel parameters. >> This will make the code easier without the need for the counter offset being sent from hostapd to kernel. > would that not break the kernel if you run it with an older version of > hostapds, unless we add 2 APIs for this in parallel, which would be > undesirable ? I see your point but the current patchset makes the > feature aligned with what we already have. Also keep in mind that there >are !mac80211 drivers out there and hostapd can run on !linux systems. So maybe channel switch flow will be more difficult to change now after already integrated with many vendors/users. But for BSS color, I really don’t see why it must go through hostapd. Kernel can add the IE (after __ieee80211_beacon_add_tim()), handle the counter decrement and notify hostapd with the new color once done. I mean, _If_ we all agree this is a better design, than we shouldn’t follow the Channel switch implementation. What do you think ? ________________________________ The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any retransmission, dissemination, copying or other use of, or taking of any action in reliance upon this information is prohibited. If you received this in error, please contact the sender and delete the material from any computer. Nothing contained herein shall be deemed as a representation, warranty or a commitment by Celeno. No warranties are expressed or implied, including, but not limited to, any implied warranties of non-infringement, merchantability and fitness for a particular purpose. ________________________________ _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
