Hi, >> Channel switch is invoked from user-space while collision will always >> be invoked from kernel. >> Driver/mac80211 can handle the cca IE addition/counter and update >> hostapd with the new color when finish CAC. >> This way, kernel can determine the initial color >> (random/fixed/scan/other method) and update hostapd at startup, >> Later, upon collision handle all the change (including IE addition >> with counter) in kernel and update hostapd with the new color once >> done. > I'm not sure this is a good idea? > What if this collides with hostapd updating the beacon? Or what if > hostapd wants to change the color later for some reason? Or if we get a > concurrent CSA? > Especially that last point seems a bit tricky, if we have it both in > hostapd at least we can decide not to do them in parallel? > OTOH, if we do this one in the kernel it might be a bit easier to do > them in parallel (at the expense of the more complex code), but is that > desirable? Will clients understand it? I don’t see how it will collide, Hostapd updates the ap->beacon (using NL80211_CMD_SET_BEACON) independently. __ieee80211_beacon_get() can than add IE's which doesn’t involve hostapd (i.e. hostapd not necessarily need to be aware of). Similar to: __ieee80211_beacon_add_tim(). Hostapd will be informed once the counter reaches 0 so it will update the HE operation IE with the new color. I actually have such patch and I can share them if that’s OK with John. Thinking about it, channel switch announcement IE can also be added in kernel the same way. Hostapd will be informed once channel switch is done (counter reached 0) so it will update the new channel parameters. This will make the code easier without the need for the counter offset being sent from hostapd to kernel. ________________________________ The information transmitted is intended only for the person or entity to which it is addressed and may contain confidential and/or privileged material. Any retransmission, dissemination, copying or other use of, or taking of any action in reliance upon this information is prohibited. If you received this in error, please contact the sender and delete the material from any computer. Nothing contained herein shall be deemed as a representation, warranty or a commitment by Celeno. No warranties are expressed or implied, including, but not limited to, any implied warranties of non-infringement, merchantability and fitness for a particular purpose. ________________________________ _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
