On Wed, Jan 08, 2020 at 06:12:28PM +0800, neojou@xxxxxxxxx wrote: > This patch is to extend the existing hw_mode=any to cover > the not-offloaded-ACS case. > > In wpa_driver_nl80211_postprocess_modes, the approach, similar > to the one for 80211.b is used for the mode > HOSTAPD_MODE_IEEE80211ANY. it is for hostapd_select_hw_mode() > to get the support configured mode. That does not sound reasonable. Why would we need to duplicate channel list entries? IEEE 802.11b is a very special case on this front and it must not be tried to be duplicated for hw_mode=any which is a completely different use case (select any of the already existing modes; not create a new mode). > And after ACS computed, the current_mode is changed back to B/G/A/AD, > depends on the frequency ACS decided. > > By this way, "hw_mode=any" can be used for not-offloaded-ACS case. This needs to work without generating duplicated channel list entries. In other words, ACS code needs to combine channels from multiple hw_mode lists to determine which channels needs to be surveyed and then pick the best one and update hw_mode based on that. I would not expect to see any changes in src/drivers/driver_*.c for this. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
