On Sat, Jan 04, 2020 at 11:10:04PM +0100, Alexander Wetzel wrote:
> +enum key_flag {
> + KEY_FLAG_MODIFY = BIT(0),
> + KEY_FLAG_DEFAULT = BIT(1),
> + KEY_FLAG_RX = BIT(2),
> + KEY_FLAG_TX = BIT(3),
> + KEY_FLAG_GROUP = BIT(4),
> + KEY_FLAG_PAIRWISE = BIT(5),
> + KEY_FLAG_PMK = BIT(6),
How much of this is really needed for new functionality vs. cleaning up?
I'm not necessarily against these flags, but I'll note that the addr
parameter is already documented to indicate broadcast vs. default vs.
unicast keys.
> diff --git a/src/drivers/driver.h b/src/drivers/driver.h
> @@ -2359,7 +2400,7 @@ struct wpa_driver_ops {
> int (*set_key)(const char *ifname, void *priv, enum wpa_alg alg,
> const u8 *addr, int key_idx, int set_tx,
> const u8 *seq, size_t seq_len,
> - const u8 *key, size_t key_len);
> + const u8 *key, size_t key_len, enum key_flag key_flag);
Instead of doing these set_key() prototype changes in driver.h and all
driver_*.c in this patch 5/16 and then repeat that in 9/16, maybe it
would make more sense to have a new patch before 5/16 that converts
set_key() to take in a struct of parameter values similarly to
associate(). In other words, only take in void *priv and struct
wpa_driver_key_params *params. This change would only touch
src/drivers/* and the set_key() wrapper functions in
wpa_supplicant/driver_i.h and src/ap/ap_drv_ops.c. Addition of a new
key_flag into the struct could then be done without having to touch any
driver_*.c and similarly, removal of set_tx would be trivial once there
are no remaining users for it.
--
Jouni Malinen PGP id EFC895FA
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
