Re: [PATCH] ACS: decide offload by hw_mode without special cmd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Thanks for your kind reply. As you mentioned as below, I understand
the design  philosophy of hw_mode now, and please abandon this patch.
Will try to find another approach to do it.

>"That is the only currently implemented case, but that hw_mode=any could
 >certainly be made to work with the not-offloaded ACS case "

> it would be much
> more valuable to make hw_mode=any work with such a driver (i.e., with
>  the not offloaded ACS version). "


> Jouni Malinen <j@xxxxx>
>
> On Fri, Jan 03, 2020 at 10:23:32AM +0800, Neo Jou wrote:
> > In the hostapd.conf, it is said that
> > "a special value "any" can be used to indicate that any support band can be
> >  used. This special case is currently supported only with drivers with
> > which offloaded ACS is used.".
> >
> > And in the current hostapd program, it fails if we set "hw_mode=any"
> > without QCA_WLAN_VENDOR_FEATURE_SUPPORT_HW_MODE_ANY.
> >
> > So it seems hw_mode=any is only for ACS offload case.
>
> That is the only currently implemented case, but that hw_mode=any could
> certainly be made to work with the not-offloaded ACS case and that would
> be the correct approach to take here. At its simplest form, this could
> pick any one of the bands that the driver supports and fill in hw_mode
> based on that.
>
> > The doubt is that  "hw_mode=any has nothing to say on whether ACS
> > should or should not be offloaded" as you said. Based on the
> > description in hostapd.conf and the behavior at the hostapd program,
> > it seems "hw_mode=any" is only for ACS offloaded.
>
> It is not in any way implying that the configuration item would be
> designed to work only with the offloaded case and no such implication
> should be made explicit by breaking this for any use case. There is no
> point in changing the meaning of hw_mode=any if the goal is to make that
> work with a driver that does not use ACS offloading; it would be much
> more valuable to make hw_mode=any work with such a driver (i.e., with
> the not offloaded ACS version).
>
> --
> Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux