On Sat, Jan 04, 2020 at 11:03:13PM +0100, Johannes Berg wrote: > On Fri, 2020-01-03 at 22:18 +0100, Benjamin Berg wrote: > > diff --git a/tests/hwsim/start.sh b/tests/hwsim/start.sh > > -test -f /proc/modules && sudo modprobe mac80211_hwsim radios=7 channels=$NUM_CH support_p2p_device=0 dyndbg=+p > > +test -f /proc/modules && sudo modprobe mac80211_hwsim radios=7 channels=$NUM_CH support_p2p_device=1 dyndbg=+p > > I'm not sure you really should change the default for this. No, that would apply to all existing test cases and would result in reduced testing coverage. In addition, this would not actually apply at all to any testing done in VMs since module parameters are set in vm/vm-run.sh for that. > However, you *can* create a (temporary) hwsim radio with hwsim netlink > (there's a class for that somewhere in the tests) using the > HWSIM_ATTR_SUPPORT_P2P_DEVICE attribute, so you could do that for this > particular test. That's exactly what I changes this test case to do after noticing it was passing for me (in a VM..) without patch 1/2 applied. In other words, both patches are now applied. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
