On Tue, Feb 12, 2019 at 10:20:04PM +0000, Ethan Everett wrote:
> This commit changes the failover behavior of RADIUS client. Commit
> 27ebadccfb2 ("RADIUS client: Cease endless retry for message for
> multiple servers") changed the retry logic, causing RADIUS client to
> wait RADIUS_CLIENT_NUM_FAILOVER + 1 timeouts before failing over the
> first time. Prior to that commit, RADIUS client would wait
> RADIUS_CLIENT_NUM_FAILOVER timeouts before each failover. This was
> caused by moving the entry->attempts > RADIUS_CLIENT_NUM_FAILOVER
> comparison to before the retry attempt, where entry->attempts is
> incremented.
>
> The commit in question set entry->attempts in radius_change_server to 1
> instead of 0, so RADIUS client would still only wait
> RADIUS_CLIENT_NUM_FAILOVER timeouts for subsequent failovers, the same
> as the original behavior.
>
> This commit changes the comparison so the initial failover now happens
> after waiting RADIUS_CLIENT_NUM_FAILOVER timeouts, as it did originally.
> It also changes the RADIUS_CLIENT_MAX_FAILOVER comparison to prevent an
> additional attempt to the primary server after the final failover.
Thanks, applied.
--
Jouni Malinen PGP id EFC895FA
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
