On Thu, Sep 05, 2019 at 12:34:40PM +0300, bilalhp@xxxxxxxxx wrote: > From: Bilal Hatipoglu <bilal.hatipoglu@xxxxxxxxxxx> > > Application Extension attribute is defined in WPS Spec v2.06 page 105. > This patch makes hostapd add this application extension data to WPS IE > if configured. The implementation is very similar to vendor extension. > > Signed-off-by: Veli Demirel <veli.demirel@xxxxxxxxxxx> > Signed-off-by: Bilal Hatipoglu <bilal.hatipoglu@xxxxxxxxxxx> > --- > src/ap/ap_config.c | 2 ++ > src/ap/ap_config.h | 1 + > src/ap/wps_hostapd.c | 29 +++++++++++++++++++++++++++++ > src/wps/wps.h | 5 +++++ > src/wps/wps_dev_attr.c | 19 +++++++++++++++++++ > src/wps/wps_registrar.c | 6 ++++-- > 6 files changed, 60 insertions(+), 2 deletions(-) How is one supposed to be able to configure these application extensions? There is no changes here to modify hostapd/config_file.c to parse anything new nor any documentation in hostapd/hostapd.conf for any new configuration parameter. There's only definition of the new configuration parameter in ap_config.h and code to free that in ap_config.c if one were somehow able to add it. > diff --git a/src/wps/wps_dev_attr.c b/src/wps/wps_dev_attr.c > @@ -242,6 +242,25 @@ int wps_build_vendor_ext(struct wps_device_data *dev, struct wpabuf *msg) > +int wps_build_application_ext(struct wps_device_data *dev, struct wpabuf *msg) A prototype for these new function needs to be added into src/wps/wps_dev_attr.h to avoid compilation warnings/errors in wps_registrar.c that calls this function. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
