Re: [PATCH] wpa_supplicant: Always use global p2p_long_listen

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Sep 18, 2019 at 05:57:30PM +0200, benjamin@xxxxxxxxxxxxxxxx wrote:
> From: Benjamin Berg <bberg@xxxxxxxxxx>
> 
> The p2p_long_listen value was set on the control wpa_s struct while in a
> lot of cases it operated on the p2p struct. Explicitly use the global
> p2p_init_wpa_s struct in cases where we might not be operating on it
> already.
> 
> Without this, simply starting a p2p_listen operation (e.g. using
> wpa_cli) will not work properly. As the p2p_long_listen is set on the
> controlling interface and the wpas_p2p_cancel_remain_on_channel_cb works
> on the p2p_init_wpa_s, it would not actually work. This results in
> wpa_supplicant to stop listening after the maximum remain-on-channel
> time passes.
> 
> --
> 
> I intent to look into creating a test case for this, but will likely
> only get around to do so next week.
> ---

Based on some offline notes, I was expecting to get an updated version
of this, but that does not seem to have happened, so I'm commenting on
this now that I'm going through the pending queue..

This was missing a Signed-off-by: line in the commit message (see the
top level CONTRIBUTIONS file for details), so I cannot apply this as-is.
I'd also be interested if that test case was ever created.

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux