Re: [PATCH] wps: add prefixes to public event_* functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 02, 2019 at 12:14:47PM -0800, Brian Norris wrote:
> openssl engines may dynamically load external libraries. Our event_*()
> functions happen to be named very generically, such that event_add()
> collides with the libevent library (https://libevent.org/). This can
> have disastrous effects (esp. when using CONFIG_WPA_TRACE, which enables
> partial linking) when our SSL engines call into the WPS event_add()
> instead of their intended libevent event_add().
> 
> Resolve this by providing a more unique prefix to these functions.
> 
> Rename performed via:
> 
>   sed -i -E \
>     's:\<event_(add|delete_all|send_all_later|send_stop_all)\>:wps_upnp_event_\1:g' \
>      $(git grep -l event_)
> 
> Tested via (among other things) hwsim '-f ap_wps' module.

Thanks, applied.
 
-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux