On Fri, Dec 06, 2019 at 05:47:00PM +0000, Pradeep Kumar Chitrapu wrote: > Incorrect parameter is being passed to hostpad_set_freq_params in > mesh which causes HE to be not enabled on 5GZ. so fix that. > diff --git a/wpa_supplicant/wpa_supplicant.c b/wpa_supplicant/wpa_supplicant.c > @@ -2410,7 +2410,7 @@ skip_ht40: > return; > > /* Enable HE for VHT */ > - vht_freq.he_enabled = mode->he_capab[ieee80211_mode].he_supported; > + freq->he_enabled = mode->he_capab[ieee80211_mode].he_supported; This looks really confusing since the comment here is clearly talking about VHT and freq might point to no-VHT parameters here. The code just above this is setting vht_freq.vht_enabled, not freq->vht_enabled. Furthermore, setting freq->he_enabled here would seem to break the expected behavior with the following return statements that try to disable VHT. Wouldn't the correct fix for this be in changing the hostapd_set_freq_params() to use vht_freq.he_enabled instead of freq->he_enabled so that the same logic can be maintained for both vht_enabled and he_enabled? -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
