Re: [Patch v8 09/15] AP: Add support for Extended Key ID

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



As always when sending out a new patch I find some issues with it:

diff --git a/src/ap/wpa_auth_ft.c b/src/ap/wpa_auth_ft.c
index 0d22aeccc..cf854a027 100644
--- a/src/ap/wpa_auth_ft.c
+++ b/src/ap/wpa_auth_ft.c
@@ -2658,7 +2658,7 @@ void wpa_ft_install_ptk(struct wpa_state_machine *sm)
  	 * again after association to get the PTK configured, but that could be
  	 * optimized by adding the STA entry earlier.
  	 */
-	if (wpa_auth_set_key(sm->wpa_auth, 0, alg, sm->addr, 0,
+	if (wpa_auth_set_key(sm->wpa_auth, 0, alg, sm->addr, sm->keyidx_active,
  			     sm->PTK.tk, klen, KEY_TYPE_PAIRWISE))
  		return;

This chunk is in the wrong patch, it belongs to patch 12 (AP: FILS Extended Key ID support)


@@ -2897,6 +2897,10 @@ static int wpa_ft_process_auth_req(struct wpa_state_machine *sm,
  		wpa_printf(MSG_DEBUG, "FT: Failed to parse FT IEs");
  		return WLAN_STATUS_UNSPECIFIED_FAILURE;
  	}
+
+	if (handle_extended_key_id(sm, parse.capabilities))
+		return WLAN_STATUS_UNSPECIFIED_FAILURE;
+
  	use_sha384 = wpa_key_mgmt_sha384(parse.key_mgmt);
  	pmk_r1_len = use_sha384 ? SHA384_MAC_LEN : PMK_LEN;

This chunk can simply be dropped. (Patch 12 is in fact already doing that.)

Alexander

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux