On Thu, Oct 17, 2019 at 6:42 PM Matthew Wang <matthewmwang@xxxxxxxxxx> wrote: (rearranged for non-top-post) > On Thu, Oct 17, 2019 at 6:35 PM Dan Williams <dcbw@xxxxxxxxxx> wrote: > > > > On Fri, 2019-10-11 at 13:49 -0700, Matthew Wang wrote: > > > These properties were in the wpas_dbus_bss_properties array when > > > they should have been in the wpas_dbus_interface_properties array. > > > Move > > > them to the right place. > > > > Haven't had time to check, but were these properties in a > > wpa_supplicant release already? Or just in git master so far? > > They are in a release. The original patch is here: > https://w1.fi/cgit/hostap/commit/?id=2bbad1c7c9cbedf16eea122c9376e65691213108 Ping? This clearly isn't what was intended, and AFAICT, the current behavior is totally buggy -- it will take interpret the 'user_data' pointer incorrectly and produce garbage instead. So can't we just take this as a bugfix without quibbling about the potential ABI break? I would bet money that the only user for these so far is Chrome OS, where our downstream variant didn't have this bug (well, not until we pulled this mis-patched version in...). Brian _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
