Re: [PATCH 1/2] HE: fix HE operation field size

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 26/04/2019 11:13, Johannes Berg wrote:
On Fri, 2019-04-26 at 00:49 +0300, Jouni Malinen wrote:
On Thu, Apr 25, 2019 at 04:57:48PM +0200, John Crispin wrote:
The current code will always use the size required when all optional
elements are present. This will cause the linux kernel to consider the
field to be malformed if the elements are not actually flagged as being
present.
Thanks, applied. I left patch 2/2 into my queue for some more review and
testing.

By the way, do you have means for testing these properly with
mac80211_hwsim? I added a minimal test case to check that the HE
elements show up in Beacon frames, but it did not look like the issue
mentioned in this patch 1/2 was showing up there and the station side
does not show any sign of trying to use HE either.
Do we even have the right APIs?

Remember we wanted to have the configuration in other attributes for the
benefit of full-MAC drivers, rather than have them parse the beacon
elements.

johannes


_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap

Ok, i'll split rts_threshold and BSS color out into extra attributes,

    John



_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux