On 3/8/19 4:07 PM, Jouni Malinen wrote: > On Thu, Mar 07, 2019 at 03:47:06PM +0100, Zefir Kurtisi wrote: >> Once the Time Advertisement elements are set, >> subsequent calls of hostapd_eid_time_adv() >> won't update the WLAN_EID_TIME_ADVERTISEMENT >> data, causing the propagated time to remain >> at its initial value during the whole >> lifetime of the AP. > > Which is by design and needed for correct functionality.. > >> This change allows updating the time whenever >> this function is called. > > This would break the advertised time information. hostapd supports only > the option of UTC time at TSF timer 0, i.e., at the time the BSS was > started. If hostapd_update_time_adv() is called again during the > lifetime of the BSS, the advertised time would be changed to be the > current time at the time this call happened which would not be the time > at TSF 0. > > If this change would be needed for some purpose, > hostapd_update_time_adv() would need to be modified to address the FIX > comment there regarding fetching the current TSF value and updating the > time stamp based on that information. > Thanks for the explanation. I did not notice the relevant comment in hostapd_update_time_adv(). Cheers, Zefir _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
