On Tue, Jan 08, 2019 at 11:04:42AM +0100, Arnout Vandecappelle wrote: > On 05/12/2018 11:24, Arnout Vandecappelle (Essensium/Mind) wrote: > > diff --git a/src/p2p/p2p_build.c b/src/p2p/p2p_build.c > > - if (wps_build_wfa_ext(buf, 0, NULL, 0) < 0) > > + if (wps_build_wfa_ext(buf, 0, NULL, 0, 0) < 0) > > These small changes make the patch very big and perhaps hard to review. Would > you like me to split off the additional argument to wps_build_wfa_ext as a > separate patch? That would certainly make it easier to review the real functional changes, so yes, that's the preferred approach for this type of refactoring cases needed for new functionality. -- Jouni Malinen PGP id EFC895FA _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap