On Tue, Jan 08, 2019 at 11:02:58AM +0100, Arnout Vandecappelle wrote:
> On 20/12/2018 11:23, Jouni Malinen wrote:
> > This looks mostly reasonable to me, but needs some coding style cleanup.
>
> Could you give me a hint about what kind of cleanup is needed? Since there is
> no coding style document, I'm probably not aware of some of the issues.
hostap.git follows Linux kernel coding style for most parts with the
main exceptions being two empty lines between functions and a space
between type case and the following item, e.g., (struct foo *) ptr.
I don't remember what exactly I identified as needing cleanup, but
things like these based on a quick look:
- empty line to be added after variable declarations in the beginning of
code blocks
- long lines (>80) to be split (with the exception of not splitting
string constants)
- two empty lines between functions (that exception to Linux coding
style mentioned above)
- no unrelated whitespace changes (first change in wps_registrar.c)
- '{' on the same line with if statements
> > That said, I want to apply this with the wpa_supplicant side
> > functionality in 10/12 and some hwsim test cases,
>
> I'll try to add some test cases. Is it better to do that as a separate patch,
> or together with the rest?
My general preference is to add AP and STA functionality in their own
patches followed by a separate patch adding test cases. Ideally all in
the same patch series.
> Also, do you like tests of corner cases that are not clearly specified by the
> Multi-AP Specification (where the test case is a kind of documentation of the
> choice we made), or do you prefer to avoid those because they'd have to be
> changed if we decide to do it differently in the end? Since you added
> test_multi_ap_fronthaul_on_ap, I guess you prefer the former?
Yes, the more testing the better and I have no issues with updating the
test cases when implementation design or draft specifications change.
--
Jouni Malinen PGP id EFC895FA
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
