Re: [PATCH v3 00/12] Multi-AP support

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 05, 2018 at 11:23:50AM +0100, Arnout Vandecappelle (Essensium/Mind) wrote:
> This series collects the different patches to add Multi-AP support to
> wpa_supplicant and hostapd.

Thanks!

> Patch 1 and 3 are new versions of
> https://patchwork.ozlabs.org/patch/1006600/ and
> https://patchwork.ozlabs.org/patch/1006601/ . The only changes are in
> the commit message.
> 
> Patch 2 and 4-9 are gradual improvements on those two patches. I've
> split them out to simplify review, but they can be squashed into patches
> 1 and 3 if that is preferred (I'm OK with dropping my authorship).

Patches 1 and 3 needed number of cleanups and fixes and it was getting
really painful to do those changes with multiple other patches in the
series getting conflicts for each change.. I ended up having to squash
the other patches into 1 and 3 to maintain sanity. Anyway, the changes
from 1-9 are now applied with cleanup and couple of fixes. In addition,
I added tests/hwsim/test_multi_ap.py with test cases to cover these
association cases for Multi-AP.

> Patch 10 and 11 are new iterations of
> https://patchwork.ozlabs.org/patch/999135/ and
> https://patchwork.ozlabs.org/patch/978101/ . They are brought inline
> with the changes introduced by patches 1 and 3, and all the things
> discussed on the mailing list are taken into account. See the commit
> message of those two patches for details.
> 
> Patch 12, finally, is an entirely new patch that adds a README for
> Multi-AP.

I have open question on 10/12 and I dropped 11/12 and 12/12 from my
queue while waiting for 10/12 to get resolved first.

> I've build-tested each individual patch, but I've only functionally
> tested the series as a whole, and only in OpenWRT context.

In general, I would highly appreciate new test cases added to
tests/hwsim to cover all new functionality proposed for hostap.git. It
should be straightforward to extend test_multi_ap.py to cover the WPS
provisioning cases as well based on WPS examples from test_ap_wps.py.

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux