Re: [PATCH 5/6] Add support for the driver init data for Intel Lantiq vendor

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 26, 2018 at 03:04:44PM +0530, Sarada Prasanna Garnayak wrote:
> When setting up the interface, send to the driver the following
> parameters via vendor commands: country_code, is_11b, is_radar_detection.

> diff --git a/src/common/intel-ltq-vendor.h b/src/common/intel-ltq-vendor.h
> @@ -55,12 +55,16 @@
>   * 	module support eapol functionality in the driver, this vendor
>   * 	cmd used to offload the eapol tx status work from hostapd
>   * 	to the driver.
> + *
> + * @INTEL_LTQ_NL80211_VENDOR_SUBCMD_INITIAL_DATA: Init vendor Data
> + * 	for country code, ieee80211b support, radar detection support.
>   */
>  enum intel_ltq_nl80211_vendor_subcmds {
>  	INTEL_LTQ_NL80211_VENDOR_SUBCMD_UNSPEC = 0,
>  	INTEL_LTQ_NL80211_VENDOR_SUBCMD_GET_AID = 1,
>  	INTEL_LTQ_NL80211_VENDOR_SUBCMD_FREE_AID = 2,
>  	INTEL_LTQ_NL80211_VENDOR_SUBCMD_TX_EAPOL = 3,
> +	INTEL_LTQ_NL80211_VENDOR_SUBCMD_INITIAL_DATA = 4,
>  };

As far as location for different definitions and implementation is
concerned, this is a good example of what could be in this header file
while everything following this should not..

As far as the proposed vendor specific parameters are concerned, isn't
country code and IEEE 802.11b related information already available
through upstream cfg80211? If not, I'd rather consider adding these in
upstream nl80211 (and same for that radar detection/802.11h part) so
that they would be available in more generic manner for all drivers.

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux