Re: [PATCH 4/6] Add vendor cmd for the eapol Tx/Rx handle for Intel Lantiq

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Nov 26, 2018 at 03:04:31PM +0530, Sarada Prasanna Garnayak wrote:
> Implement sending and receiving eapol frames via nl80211
> vendor commands for Intel Ltq vendor.

Could you please clarify why you think this would need a vendor specific
interface? EAPOL frame TX/RX has been a long pending to-do item for
upstream nl80211. It would be much more valuable to do this through the
upstream nl80211 interface shared by multiple drivers.

> diff --git a/src/common/intel-ltq-vendor.h b/src/common/intel-ltq-vendor.h

> +static inline void
> +intel_ltq_nl80211_handle_eapol(struct wpa_driver_nl80211_data *drv,
> +			       const u8 *data, size_t len)
...

And as noted for the previous patch, these inline functions do not
belong in a header file that defines vendor specific identifiers;
instead, they would be somewhere in a C file in src/drivers.

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux