On 05/31/2018 01:55 AM, Jouni Malinen wrote:
On Tue, May 29, 2018 at 02:39:06PM -0700, peter.oh@xxxxxxxxxxxxxxxxx wrote:
RSN initialization can be used in different phases
if mesh initialization and mesh join don't happen
in sequence such as DFS CAC is done in between,
hence factor it out to help convering the case.
There is only a single call to wpas_mesh_init_rsn() after this patch
series. Could you please clarify why this factoring out is done?
in the later patch, "use setup completion callback to complete mesh",
this factored out function is moving to "wpas_mesh_complete_cb()" which
is not called before CAC is done, but only called after CAC is done. The
original code which initializes RSN is a part of
wpa_supplicant_mesh_init() that is called always regardless of CAC is
done or not which leads auth failure when CAC is required.
diff --git a/wpa_supplicant/mesh.c b/wpa_supplicant/mesh.c
@@ -147,6 +147,53 @@ static void wpas_mesh_copy_groups(struct hostapd_data *bss,
+int wpas_mesh_init_rsn(struct wpa_supplicant *wpa_s)
And why would this function not be a static function since the only user
remains in mesh.c through this patch series?
Will update in next patchset.
Thanks,
Peter
_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap
