Re: [PATCH v5 02/17] mesh: factor out rsn initialization

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, May 29, 2018 at 02:39:06PM -0700, peter.oh@xxxxxxxxxxxxxxxxx wrote:
> RSN initialization can be used in different phases
> if mesh initialization and mesh join don't happen
> in sequence such as DFS CAC is done in between,
> hence factor it out to help convering the case.

There is only a single call to wpas_mesh_init_rsn() after this patch
series. Could you please clarify why this factoring out is done?

> diff --git a/wpa_supplicant/mesh.c b/wpa_supplicant/mesh.c
> @@ -147,6 +147,53 @@ static void wpas_mesh_copy_groups(struct hostapd_data *bss,
> +int wpas_mesh_init_rsn(struct wpa_supplicant *wpa_s)

And why would this function not be a static function since the only user
remains in mesh.c through this patch series?

-- 
Jouni Malinen                                            PGP id EFC895FA

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux