Re: [PATCH] dbus: Expose connected stations on D-Bus

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2018-05-10 at 17:07 -0400, Mathieu Trudel-Lapierre wrote:
> On Thu, May 10, 2018 at 1:07 PM, Andrej Shadura
> <andrew.shadura@xxxxxxxxxxxxxxx> wrote:
> > On 08/05/18 18:53, Dan Williams wrote:
> > > On Mon, 2018-05-07 at 20:19 +0200, Andrej Shadura wrote:
> > > > From: Mathieu Trudel-Lapierre <mathieu.trudel-lapierre@canonica
> > > > l.com>
> > > > 
> > > > Make it possible to list connected stations in AP mode over D-
> > > > Bus,
> > > > along
> > > > with some of their properties: rx/tx packets, bytes,
> > > > capabilities,
> > > > etc.
> > > 
> > > It looks like this patch changes the signal signature of
> > > StaAuthorized/StaDeauthorized, is that correct?  That won't be
> > > backwards compatible with existing D-Bus clients and we should
> > > probably
> > > choose new signal names to allow old clients to continue working.
> > 
> > Hmm, indeed it does, and it probably shouldn’t. What would you call
> > a
> > new signal with the new signature?
> > 
> > Mathieu, what applications rely on the proposed new signature of
> > this
> > signal?
> > 
> 
> I had written this a long while ago to use to inform GPS software,
> that would help triagulate using APs in range.
> 
> FWIW, I won't need it at this point; feel free to rework the code to
> your heart's content if you can make use of it. :)

Andrej/Mathieu,

I think the patch is useful and I think there are fairly simple ways to
make it not break D-Bus API. Would either of you be able to make some
of those changes?

Perhaps instead of changing wpas_dbus_signal_sta() and the
corresponding signature, an additional signal (emitted at the same
time) could be "StationAdded"/"StationRemoved" with properties since we
now have a "Stations" property and real station objects.

Dan

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux