Re: [PATCH 1/2] wpa_cli: Fix duplicate const warning

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2018/02/03 19:19, Jouni Malinen wrote:
> That's wrong..
> 
>> diff --git a/wpa_supplicant/wpa_cli.c b/wpa_supplicant/wpa_cli.c
>> -static const char const *cred_fields[] = {
>> +static const char *cred_fields[] = {
> 
> But this is not the fix.. I'd assume this was supposed to be an array of
> const-pointer to const-char, so I'll replace this with 'const char *
> const' instead.

The cred_fields looks be used by only one function. So how about making it local
variable and using the name "fields" ? Just like wpa_cli_complete_get_capability().

Masashi Honma.

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux