On 2017/03/29 21:02, Jouni Malinen wrote:
nla_put_s32() is a recent addition to libnl and this would break builds with most released versions.. Can we use nla_put_u32 instead()? Or add a backwards compatibility wrapper for this?
Oh, thanks ! I will replace it to nla_put_u32. To validate the setting of the negative value, I will add a test.
Would it be better to add WPA_DRIVER_MESH_CONF_FLAG_RSSI_THRESHOLD only if the configuration value is actually set? This would leave the current behavior of kernel using its default value (which may happen to be the same as the default in wpa_supplicant) more consistent rather than moving this to be enforced by whatever the wpa_supplicant default value is.
I see. I will modify to set wpa_supplicant value always. Masashi Honma. _______________________________________________ Hostap mailing list Hostap@xxxxxxxxxxxxxxxxxxx http://lists.infradead.org/mailman/listinfo/hostap
