Re: [PATCH v2] rfkill: match only the correct expected wiphy rfkill

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2015-12-09 at 08:55 +0100, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@xxxxxxxxx>
> 
> On systems that have multiple WLAN rfkill instances, the rfkill code
> can become confused into thinking that the device was unblocked when
> in fact it wasn't, because it only matches on the WLAN type.
> 
> Since it then stores the new (unblocked) state from the wrong rfkill
> instance, it will never retry the failing IFF_UP operation and the
> user has to toggle rfkill again, or otherwise intervene manually, in
> this case to get back to operational.
> 
> Fix this by using the existing (but unused) ifname argument when the
> rfkill instance is created to match to a specific rfkill index only.
> 
Ilan found that this is broken for p2p-device, for obvious reasons (not
having a netdev, so no sysfs entry for the netdev).

We probably should change the rfkill_init() API to pass the wiphy
instead of the netdev - we'll fix it.

johannes

_______________________________________________
Hostap mailing list
Hostap@xxxxxxxxxxxxxxxxxxx
http://lists.infradead.org/mailman/listinfo/hostap



[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux