On 12/15/2009 01:19 PM, Pete Zaitcev wrote:
On Mon, 14 Dec 2009 18:18:47 -0800
Colin McCabe<cmccabe@xxxxxxxxxxxxxx> wrote:
Also my new patch creates a hail_log.h. It didn't really seem right to
force everyone who wanted to use HAIL_LOG to include cldc.h.
I'll convert over the rest of chunkd and tabled to the new macros if
this patch series gets accepted (but not in this patch series!)
You know what else would be nice? I find it irritating to include
<syslog.h> everywhere due to 1:1 mapping of LOG_XXX values.
I'm inclined to think that a switch(){} in applog() would be an
acceptable price for getting rid of it.
In fact, does anyone even understand why we continue to split
LOG_WARNING and LOG_ERR? We really have three log levels:
- debug
- info (which is actually an error)
- error (not really all that different from info actually)
Might as well create HAIL_DEBUG, HAIL_INFO, and HAIL_ERR (to be
used before exit(1), with values of 0,1,2 and remap to syslog
values where it goes to syslog.
It would be nice to disconnect from syslog, yes. But the 'warning' log
level has value.
Jeff
--
To unsubscribe from this list: send the line "unsubscribe hail-devel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
