On Mon, Dec 14, 2009 at 12:36 PM, Jeff Garzik <jeff@xxxxxxxxxx> wrote: > On 12/14/2009 02:23 AM, Colin McCabe wrote: >> >> Hi all, >> >> I think I'm going to respin this patch to be a lot smaller. Just >> refactor one or two things, but leave the existing "verbose" and >> "applog" system in place. Let me know what you think-- do you think I >> should push ahead with HAIL_DEBUG etc., > > Well... I was waiting until today to see if downstream API-related patches > would appear. Prior to CLD version 1.0, the "rules" are that any and all > network protocol or client API changes are OK. After 1.0, we will need to > take typical userland library precautions to properly version API changes, > avoid breakage, etc. > > However, even prior to v1.0, API changes do introduce breakage in chunkd and > tabled. Typically, if you make a client API change, patches to update the > other projects should be provided as well. > > So I was leaning towards applying and then fixing up chunkd/tabled myself, > but any proposed alternative described as "just refactor a thing or two" is > certainly very appealing :) I have some patches to get chunkd and tabled compiling, but I'd need to run them through some minimal testing. Also my new patch creates a hail_log.h. It didn't really seem right to force everyone who wanted to use HAIL_LOG to include cldc.h. I'll convert over the rest of chunkd and tabled to the new macros if this patch series gets accepted (but not in this patch series!) > > It's up to you... > Logic says I shouldn't waste time repainting the logging bike shed. But then I see a two-line comment turn into five lines because of indentation, and I just want to put a new coat of paint on that thing. Anyway, I'll post the patches for the full thing in a bit. Colin -- To unsubscribe from this list: send the line "unsubscribe hail-devel" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
