On Sat, Apr 06, 2024 at 06:35:22PM -0400, Jackson Chui wrote:
> > -Alex
>
> Dan, Alex I think both of you are spot on.
>
> I like the suggestion of adding 'gcam_dev()' as an accessor
> function and directly calling to 'dev_*'. I'm busy this weekend
> but will send out a new patch with this change next week.
Nah, don't bother with adding the gcam_dev() function. Like Alex says,
it's only 4 characters shorter. Just get rid of the macros and do:
dev_err(&gcam->bundle->dev,
"Unsupported unsolicited event: %u\n", op->type);
regards,
dan carpenter
_______________________________________________
greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx
To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx
|