On 19/03/2024 07:47, Ayush Singh wrote: > On 3/19/24 11:34, Krzysztof Kozlowski wrote: > >> On 17/03/2024 20:37, Ayush Singh wrote: >>> DONOTMERGE >>> >>> this patch depends on Patch 1, 2, 3 >> So none of your work should be reviewed? I don't understand this, but in >> such case I am not going to review it. >> >> Best regards, >> Krzysztof >> > I am a bit lost here. It was mentioned in the patch v3 that I should > specify the interdependence of patches in v3. And now you are saying I > should not? > > Here is the rationale for the dependence: > > 1. Any changes to the property names in dt-bindings patch 1 will need an > appropriate change here. > > 2. This patch will fail to build without patch 2. > > 3. This patch will fail to build without patch 3. This is a natural ordering of patches... but the point is that it makes ZERO sense once applied to Git repo. Your commit *MUST* make sense in the Git. Now it does not. Explain in cover letter what is the merging strategy. You can also mention in patch changelog (---) that one patch must be applied toogether with another. Best regards, Krzysztof _______________________________________________ greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx
|