On 19/03/2024 07:34, Ayush Singh wrote:
>
> On 3/19/24 11:29, Krzysztof Kozlowski wrote:
>> On 17/03/2024 20:37, Ayush Singh wrote:
>>> DONOTMERGE
>> Why? Explain then the purpose of this patch.
>
> Well, it was suggested to have DONOTMERGE by Vaishnav in the patches
> until dt bindings have been approved, since this patch touches different
> subsystems. Here is the full context from v3:
>
>> The reasoning behind this is that these patches go in to separate maintainer trees and without the bindings merged first the device tree changes cannot be validated, thus it is a usual practice to get the bindings and driver merged first and the device tree changes to go in the next cycle. Another alternative is you can point to your fork with all the changes together.
This is some odd style of work. Please don't follow such advise.
>
>>> this patch depends on patch 1
>> How? I don't see any dependency.
>
> I think it is not allowed to have code in device tree unless a
> corresponding dt-binding exists for the device. And thus every time the
And you provided the binding.
> dt-binding changes, this patch also needs to change.So I thought it is
> dependent on patch 1.
But it is not a dependency. Dependency means something does not work
without another. Or something must be applied in the same branch as
another. None of the cases are here. Drop the statements.
This is no different than all of our regular works. Do you see any of
such comments ("dont merge", "dependency")? No.
Best regards,
Krzysztof
_______________________________________________
greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx
To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx
|