Re: [PATCH 1/1] greybus: es2: Remove extra newline

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]


Thanks, Alex Elder and Greg KH. I created the patch since I wanted to check out the whole git-send-email patch workflow and get better acquainted with things before submitting the beagle play greybus driver[1] I have been working on.

I will probably ask a few questions pertaining to the driver organization over at kernelnewbies before creating a full patch for the driver.

Ayush Singh


On 7/31/23 17:02, Alex Elder wrote:
On 7/30/23 2:47 PM, Ayush Singh wrote:
This patch removes some blank lines in order to fix a checkpatch issue.

Signed-off-by: Ayush Singh <ayushdevel1325@xxxxxxxxx>

FYI, others have suggested making a change like this before.  This
additional blank line is not harmful, and is used in several places
in the Greybus code.  It is coding style that makes a bit clearer
separation between sections of code.  It is not typical Linux kernel
coding style, and yes, reports it, but when it has
been suggested in the past Johan said he preferred to keep it the
way it is now.

So if you'd like to do another trivial patch (in the Greybus code),
please find a different "error" reported by to fix.


  drivers/greybus/es2.c | 1 -
  1 file changed, 1 deletion(-)

diff --git a/drivers/greybus/es2.c b/drivers/greybus/es2.c
index e89cca015095..1727914dd1a4 100644
--- a/drivers/greybus/es2.c
+++ b/drivers/greybus/es2.c
@@ -17,7 +17,6 @@
  #include "arpc.h"
  #include "greybus_trace.h"
  /* Default timeout for USB vendor requests. */
  #define ES2_USB_CTRL_TIMEOUT    500

greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx
To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx

[Index of Archives]     [Asterisk App Development]     [PJ SIP]     [Gnu Gatekeeper]     [IETF Sipping]     [Info Cyrus]     [ALSA User]     [Fedora Linux Users]     [Linux SCTP]     [DCCP]     [Gimp]     [Yosemite News]     [Deep Creek Hot Springs]     [Yosemite Campsites]     [ISDN Cause Codes]     [Asterisk Books]

  Powered by Linux