On 7/30/23 2:47 PM, Ayush Singh wrote:
This patch removes some blank lines in order to fix a checkpatch issue. Signed-off-by: Ayush Singh <ayushdevel1325@xxxxxxxxx>
FYI, others have suggested making a change like this before. This additional blank line is not harmful, and is used in several places in the Greybus code. It is coding style that makes a bit clearer separation between sections of code. It is not typical Linux kernel coding style, and yes, checkpatch.pl reports it, but when it has been suggested in the past Johan said he preferred to keep it the way it is now. So if you'd like to do another trivial patch (in the Greybus code), please find a different "error" reported by checkpatch.pl to fix. -Alex
--- drivers/greybus/es2.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/greybus/es2.c b/drivers/greybus/es2.c index e89cca015095..1727914dd1a4 100644 --- a/drivers/greybus/es2.c +++ b/drivers/greybus/es2.c @@ -17,7 +17,6 @@ #include "arpc.h" #include "greybus_trace.h"-/* Default timeout for USB vendor requests. */ #define ES2_USB_CTRL_TIMEOUT 500
_______________________________________________ greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx
|