Re: [PATCH 2/7] i2c: core: Use generic_handle_irq_safe() in i2c_handle_smbus_host_notify().
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
- Subject: Re: [PATCH 2/7] i2c: core: Use generic_handle_irq_safe() in i2c_handle_smbus_host_notify().
- From: Wolfram Sang <wsa@xxxxxxxxxx>
- Date: Thu, 27 Jan 2022 18:11:16 +0100
- In-reply-to: <20220127113303.3012207-3-bigeasy@linutronix.de>
- Mail-followup-to: Wolfram Sang <wsa@xxxxxxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, greybus-dev@xxxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-staging@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Johan Hovold <johan@xxxxxxxxxx>, Lee Jones <lee.jones@xxxxxxxxxx>, Rui Miguel Silva <rmfrfs@xxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, UNGLinuxDriver@xxxxxxxxxxxxx, Woojung Huh <woojung.huh@xxxxxxxxxxxxx>, Michael Below <below@xxxxxxxx>, Salvatore Bonaccorso <carnil@xxxxxxxxxx>
- References: <20220127113303.3012207-1-bigeasy@linutronix.de> <20220127113303.3012207-3-bigeasy@linutronix.de>
On Thu, Jan 27, 2022 at 12:32:58PM +0100, Sebastian Andrzej Siewior wrote:
> The i2c-i801 driver invokes i2c_handle_smbus_host_notify() from his
> interrupt service routine. On PREEMPT_RT i2c-i801's handler is forced
> threaded with enabled interrupts which leads to a warning by
> handle_irq_event_percpu() assuming that irq_default_primary_handler()
> enabled interrupts.
>
> i2c-i801's interrupt handler can't be made non-threaded because the
> interrupt line is shared with other devices.
>
> Use generic_handle_irq_safe() which can invoked with disabled and enabled
> interrupts.
>
> Reported-by: Michael Below <below@xxxxxxxx>
> Link: https://bugs.debian.org/1002537
> Cc: Salvatore Bonaccorso <carnil@xxxxxxxxxx>
> Signed-off-by: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
I guess you want this to go together with patch 1, so:
Acked-by: Wolfram Sang <wsa@xxxxxxxxxx>
I agree with adding the kernel bugzilla entry at least:
https://bugzilla.kernel.org/show_bug.cgi?id=202453
Probably the others which Oleksandr metioned, too.
Attachment:
signature.asc
Description: PGP signature
_______________________________________________
greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx
To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx
[Index of Archives]
[Asterisk App Development]
[PJ SIP]
[Gnu Gatekeeper]
[IETF Sipping]
[Info Cyrus]
[ALSA User]
[Fedora Linux Users]
[Linux SCTP]
[DCCP]
[Gimp]
[Yosemite News]
[Deep Creek Hot Springs]
[Yosemite Campsites]
[ISDN Cause Codes]
[Asterisk Books]