Re: [PATCH 1/7] genirq: Provide generic_handle_irq_safe().
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- To: Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>
- Subject: Re: [PATCH 1/7] genirq: Provide generic_handle_irq_safe().
- From: Wolfram Sang <wsa@xxxxxxxxxx>
- Date: Thu, 27 Jan 2022 18:03:29 +0100
- In-reply-to: <20220127113303.3012207-2-bigeasy@linutronix.de>
- Mail-followup-to: Wolfram Sang <wsa@xxxxxxxxxx>, Sebastian Andrzej Siewior <bigeasy@xxxxxxxxxxxxx>, greybus-dev@xxxxxxxxxxxxxxxx, linux-i2c@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-staging@xxxxxxxxxxxxxxx, linux-usb@xxxxxxxxxxxxxxx, netdev@xxxxxxxxxxxxxxx, "David S. Miller" <davem@xxxxxxxxxxxxx>, Alex Elder <elder@xxxxxxxxxx>, Arnd Bergmann <arnd@xxxxxxxx>, Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>, Hans de Goede <hdegoede@xxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Johan Hovold <johan@xxxxxxxxxx>, Lee Jones <lee.jones@xxxxxxxxxx>, Rui Miguel Silva <rmfrfs@xxxxxxxxx>, Thomas Gleixner <tglx@xxxxxxxxxxxxx>, UNGLinuxDriver@xxxxxxxxxxxxx, Woojung Huh <woojung.huh@xxxxxxxxxxxxx>
- References: <20220127113303.3012207-1-bigeasy@linutronix.de> <20220127113303.3012207-2-bigeasy@linutronix.de>
Hi Sebastian,
> +/**
> + * generic_handle_irq_safe - Invoke the handler for a particular irq
This is the same desc as for generic_handle_irq(). I suggest to add
something like "from any context" to have some distinction.
> + * This function must be called either from an IRQ context with irq regs
> + * initialized or with care from any context.
I think "with care" is not obvious enough. Can you describe it a little?
Thanks for this work,
Wolfram
Attachment:
signature.asc
Description: PGP signature
_______________________________________________
greybus-dev mailing list -- greybus-dev@xxxxxxxxxxxxxxxx
To unsubscribe send an email to greybus-dev-leave@xxxxxxxxxxxxxxxx
[Index of Archives]
[Asterisk App Development]
[PJ SIP]
[Gnu Gatekeeper]
[IETF Sipping]
[Info Cyrus]
[ALSA User]
[Fedora Linux Users]
[Linux SCTP]
[DCCP]
[Gimp]
[Yosemite News]
[Deep Creek Hot Springs]
[Yosemite Campsites]
[ISDN Cause Codes]
[Asterisk Books]