On 7 February 2011 11:30, Pekka Enberg <penberg@xxxxxxxxxx> wrote: > Hi! > > On Thu, 2011-02-03 at 16:47 +0200, Pekka Enberg wrote: >>> I'd like to check in these simple invokedynamic API stubs into CVS HEAD. >>> The APIs are not final but I think now is as good time as any to start >>> working on them especially as it needs work on the VM side. Furthermore, >>> there's already open source projects such as JRuby out there that use >>> invokedynamic so I think GNU Classpath probably needs to support it at >>> some point anyway. >> >>> The classes don't do anything useful yet and don't even contain all >>> the specified methods. > > On Fri, Feb 4, 2011 at 10:11 AM, Mark Wielaard <mark@xxxxxxxxx> wrote: >> I have to admit that I don't like putting in stubs. In the past we have >> decided to just leave things really unimplemented if we don't support >> it. And as you say it needs a bit more design thinking. So I would >> suggest you do this on a branch first (grmbl CVS...) and/or first try to >> spec it out against a jato VM implementation. > > Sure, I want to start looking at implementing invokedynamic for Jato > which is why I implemented these stubs in the first place. I expect > that to take some time so the question is where to put the > work-in-progress implementation. I don't see any reason to keep it > stashed on my local hard disk but I have to admit I'm not entirely > happy with the idea of using CVS branches for it either... > > I guess I could keep it on my Github mirror until I have something > concrete enough to be merged to trunk. > I'd prefer to have it in HEAD as long as it's clearly marked as stubs (the NotImplementedException I mentioned) and there is work actively taking place. Then there's always the (slim) possibility someone else can work on it :-) > On Fri, Feb 4, 2011 at 10:11 AM, Mark Wielaard <mark@xxxxxxxxx> wrote: >> BTW. John Rose has lots of background material online: >> http://cr.openjdk.java.net/~jrose/pres/ > > Thanks! > > Â Â Â Â Â Â Â Â Â Â Â ÂPekka > > -- Andrew :-) Free Java Software Engineer Red Hat, Inc. (http://www.redhat.com) Support Free Java! Contribute to GNU Classpath and the OpenJDK http://www.gnu.org/software/classpath http://openjdk.java.net PGP Key: F5862A37 (https://keys.indymedia.org/) Fingerprint = EA30 D855 D50F 90CD F54D Â0698 0713 C3ED F586 2A37