Re: GCC's classpath/scripts/check_jni_methods.sh vs diff -b

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Alexandre,

On Mon, 2007-10-01 at 15:37 -0300, Alexandre Oliva wrote:
> diff -b doesn't completely ignore all whitespace, but rather only
> differences as to the amount of whitespace; so whether whitespace is
> present or not is regarded as a difference.
> 
> However, check_jni_methods.sh expects it to ignore a single trailing
> blank vs no trailing whitespace whatsoever.  diff -B does, but I don't
> think that's portable enough for us to use it.
> 
> So I've changed the regular expressions such that they'd be more
> inclusive, instead of demanding and discarding whitespace before open
> parentheses, and removed the -b then rendered unnecessary.

from  Alexandre Oliva  <aoliva@xxxxxxxxxx>

        * scripts/check_jni_methods.sh: Don't depend on diff -b ignoring
        a single trailing whitespace.

Thanks, now also committed to classpath upstream.

Cheers,

Mark



[Index of Archives]     [Linux Kernel]     [Linux Cryptography]     [Fedora]     [Fedora Directory]     [Red Hat Development]

  Powered by Linux