Re: fdlibm patch

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/27/07, Christian Thalinger <twisti@xxxxxxxxxxxxxxxxxxxxx> wrote:
> On Thu, 2007-09-27 at 19:26 +0200, Robert Schuster wrote:
> > Hi,
> > the OE guys still keep this little patch. Does anyone know if it is
> > correct and should be applied?
>

On ARM, soft floating point and the VFP coprocessor use "pure endian"
doubles rather than the original "mixed endian" doubles.

The comment implies __VFP_FP__ should be defined when __SOFTFP__ is
defined.  However, the change implies the comment is wrong because
it's unlikely it would have been changed for the hell of it.

I'd be inclined to play on the safe side and check for either.  This
is what I do in similar places in JamVM :

#if defined(__VFP_FP__) || defined(__SOFTFP__)

Rob.

> Hmm, maybe Michael knows...
>
> > --- classpath/native/fdlibm/ieeefp.h.orig       2006-04-14
> > 22:33:09.000000000 -0400
> > +++ classpath/native/fdlibm/ieeefp.h    2006-04-14 22:41:46.000000000
> > -0400
> > @@ -13,7 +13,7 @@
> >     byte ordering was big or little endian depending upon the
> > target.
> >     Modern floating-point formats are naturally ordered; in this case
> >     __VFP_FP__ will be defined, even if soft-float.  */
> > -#ifdef __VFP_FP__
> > +#ifdef __SOFTFP__
> >  #ifdef __ARMEL__
> >  #define __IEEE_LITTLE_ENDIAN
> >  #else
>
> - twisti
>
>


[Index of Archives]     [Linux Kernel]     [Linux Cryptography]     [Fedora]     [Fedora Directory]     [Red Hat Development]

  Powered by Linux