I'll make the changes for prioritizing python2 over 3 for release 5 and 4. Let me know if we need to make any other changes. Thanks! On Mon, Jul 8, 2019 at 3:07 PM Niels de Vos <ndevos@xxxxxxxxxx> wrote: > > On Mon, Jul 08, 2019 at 02:37:34PM +0530, Hari Gowtham wrote: > > I have a few concerns about adding the python3 devel package and > > continuing the build. > > In the effort to make Gluster python3 compatible, > > https://github.com/gluster/glusterfs/issues/411 > > I think we have decided to skip working on Glupy to make it python3 compatible. > > (Correct me if i'm wrong.) As Glupy was decided to be deprecated. > > Though i don't see any mail thread regarding the same. > > I don't see any patches merged to make Glupy python3 compatible, as well. > > > > In such a case, I think its better to make changes to the configure.ac > > of release 5 to work with python2 alone. > > This way, Glupy will not be affected as well. And machines with > > python3 will also work because of the presence of python2. > > And no change will be needed on the infra side as well. > > Building when only python3 is available should still keep working as > well. Recent Fedora versions do not have python2 (by default?) anymore, > and that may be true for other distributions too. > > configure.ac for release-5 and release-4.1 should probably prefer > python2 before python3. > > Niels > > > > We are a bit too late with the 5 series releases. If we are fine with > > this approach, > > I will send out a mail informing this, work on the patch and push it. > > > > > > On Fri, Jul 5, 2019 at 6:48 PM Niels de Vos <ndevos@xxxxxxxxxx> wrote: > > > > > > On Thu, Jul 04, 2019 at 05:03:53PM +0200, Michael Scherer wrote: > > > > Le jeudi 04 juillet 2019 à 16:20 +0200, Niels de Vos a écrit : > > > > > On Wed, Jul 03, 2019 at 04:46:11PM +0200, Michael Scherer wrote: > > > > > > Le mercredi 03 juillet 2019 à 20:03 +0530, Deepshikha Khandelwal a > > > > > > écrit : > > > > > > > Misc, is EPEL got recently installed on the builders? > > > > > > > > > > > > No, it has been there since september 2016. What got changed is > > > > > > that > > > > > > python3 wasn't installed before. > > > > > > > > > > > > > Can you please resolve the 'Why EPEL on builders?'. EPEL+python3 > > > > > > > on > > > > > > > builders seems not a good option to have. > > > > > > > > > > > > > > > > > > Python 3 is pulled by 'mock', cf > > > > > > > > > > https://lists.gluster.org/pipermail/gluster-devel/2019-June/056347.html > > > > > > > > > > > > So sure, I can remove EPEL, but then it will remove mock. Or I can > > > > > > remove python3, and it will remove mock. > > > > > > > > > > > > But again, the problem is not with the set of installed packages on > > > > > > the > > > > > > builder, that's just showing there is a bug. > > > > > > > > > > > > The configure script do pick the latest python version: > > > > > > https://github.com/gluster/glusterfs/blob/master/configure.ac#L612 > > > > > > > > > > > > if there is a python3, it take that, if not, it fall back to > > > > > > python2. > > > > > > > > > > > > then, later: > > > > > > https://github.com/gluster/glusterfs/blob/master/configure.ac#L639 > > > > > > > > > > > > it verify the presence of what is required to build. > > > > > > > > > > > > So if there is a runtime version only of python3, it will detect > > > > > > python3, but not build anything, because the -devel subpackage is > > > > > > not h > > > > > > ere. > > > > > > > > > > > > There is 2 solutions: > > > > > > - fix that piece of code, so it doesn't just test the presence of > > > > > > python executable, but do that, and test the presence of headers > > > > > > before > > > > > > deciding if we need to build or not glupy. > > > > > > > > > > > > - use PYTHON env var to force python2, and document that it need to > > > > > > be > > > > > > done. > > > > > > > > > > What about option 3: > > > > > > > > > > - install python3-devel in addition to python3 > > > > > > > > That's a option, but I think that's a disservice for the users, since > > > > that's fixing our CI to no longer trigger a corner case, which doesn't > > > > mean the corner case no longer exist, just that we do not trigger it. > > > > > > This is only interesting for building releases/packages, I think. Normal > > > build environments have -devel packages installed for the components > > > that are used during the build process. The weird python2-devel and > > > python3 (without -devel) is definitely a corner case, but not something > > > people would normally have. And if so, we expect -devel for the python > > > version that is used, so developers would hopefully just install that on > > > their build system. > > > > > > Niels > > > _______________________________________________ > > > > > > Community Meeting Calendar: > > > > > > APAC Schedule - > > > Every 2nd and 4th Tuesday at 11:30 AM IST > > > Bridge: https://bluejeans.com/836554017 > > > > > > NA/EMEA Schedule - > > > Every 1st and 3rd Tuesday at 01:00 PM EDT > > > Bridge: https://bluejeans.com/486278655 > > > > > > Gluster-devel mailing list > > > Gluster-devel@xxxxxxxxxxx > > > https://lists.gluster.org/mailman/listinfo/gluster-devel > > > > > > > > > -- > > Regards, > > Hari Gowtham. -- Regards, Hari Gowtham. _______________________________________________ Community Meeting Calendar: APAC Schedule - Every 2nd and 4th Tuesday at 11:30 AM IST Bridge: https://bluejeans.com/836554017 NA/EMEA Schedule - Every 1st and 3rd Tuesday at 01:00 PM EDT Bridge: https://bluejeans.com/486278655 Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx https://lists.gluster.org/mailman/listinfo/gluster-devel
