Re: ./rfc.sh not pushing patch to gerrit

[Raghavendra Gowdappa <rgowdapp@xxxxxxxxxx>]

What is the agreed upon clang version for Glusterfs project? Is it clang-6?

On Fri, Oct 5, 2018 at 1:58 PM Raghavendra Gowdappa <rgowdapp@xxxxxxxxxx> wrote:

clang-4.0.1 pushes patch, but still doesn't understand some keys in clang-format.

[rgowdapp@rgowdapp glusterfs]$ ./rfc.sh 

[detached HEAD 401a7b6] cluster/dht: clang-format dht-common.c

 1 file changed, 10674 insertions(+), 11166 deletions(-)

 rewrite xlators/cluster/dht/src/dht-common.c (88%)

[detached HEAD 2bf5031] cluster/dht: fixes to unlinking invalid linkto file

 1 file changed, 236 insertions(+), 268 deletions(-)

Successfully rebased and updated refs/heads/1635145.

YAML:35:23: error: unknown key 'SplitEmptyFunction'

  SplitEmptyFunction: true

                      ^~~~

On Fri, Oct 5, 2018 at 10:47 AM Raghavendra Gowdappa <rgowdapp@xxxxxxxxxx> wrote:

We should document (better still add checks in rfc.sh and warn user to upgrade) that we need clang version x or greater.

On Fri, Oct 5, 2018 at 10:45 AM Sachidananda URS <surs@xxxxxxxxxx> wrote:

On Fri, Oct 5, 2018 at 10:41 AM, Raghavendra Gowdappa <rgowdapp@xxxxxxxxxx> wrote:

General options:

  -help                     - Display available options (-help-hidden for more)
  -help-list                - Display list of available options (-help-list-hidden for more)
  -version                  - Display the version of this program
[rgowdapp@rgowdapp ~]$ clang-format -version ; echo $?
LLVM (http://llvm.org/):
  LLVM version 3.4.2
  Optimized build.
  Built Dec  7 2015 (09:37:36).
  Default target: x86_64-redhat-linux-gnu
  Host CPU: x86-64
1

It is a bug then, which they've fixed later on. Upgrade is the only choice.

_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
https://lists.gluster.org/mailman/listinfo/gluster-devel