Re: ./rfc.sh not pushing patch to gerrit

[Raghavendra Gowdappa <rgowdapp@xxxxxxxxxx>]

On Fri, Oct 5, 2018 at 9:58 AM Sachidananda URS <surs@xxxxxxxxxx> wrote:

On Fri, Oct 5, 2018 at 9:45 AM, Raghavendra Gowdappa <rgowdapp@xxxxxxxxxx> wrote:

On Fri, Oct 5, 2018 at 9:34 AM Raghavendra Gowdappa <rgowdapp@xxxxxxxxxx> wrote:

On Fri, Oct 5, 2018 at 9:11 AM Kaushal M <kshlmster@xxxxxxxxx> wrote:

On Fri, Oct 5, 2018 at 9:05 AM Raghavendra Gowdappa <rgowdapp@xxxxxxxxxx> wrote:
>
>
>
> On Fri, Oct 5, 2018 at 8:53 AM Amar Tumballi <atumball@xxxxxxxxxx> wrote:
>>
>> Can you try below diff in your rfc, and let me know if it works?
>
>
> No. it didn't. I see the same error.
>  [rgowdapp@rgowdapp glusterfs]$ ./rfc.sh
> + rebase_changes
> + GIT_EDITOR=./rfc.sh
> + git rebase -i origin/master
> [detached HEAD e50667e] cluster/dht: clang-format dht-common.c
>  1 file changed, 10674 insertions(+), 11166 deletions(-)
>  rewrite xlators/cluster/dht/src/dht-common.c (88%)
> [detached HEAD 0734847] cluster/dht: fixes to unlinking invalid linkto file
>  1 file changed, 1 insertion(+), 1 deletion(-)
> [detached HEAD 7aeba07] rfc.sh: test - DO NOT MERGE
>  1 file changed, 8 insertions(+), 3 deletions(-)
> Successfully rebased and updated refs/heads/1635145.
> + check_backport
> + moveon=N
> + '[' master = master ']'
> + return
> + assert_diverge
> + git diff origin/master..HEAD
> + grep -q .
> ++ git log -n1 --format=%b
> ++ grep -ow -E '([fF][iI][xX][eE][sS]|[uU][pP][dD][aA][tT][eE][sS])(:)?[[:space:]]+(gluster\/glusterfs)?(bz)?#[[:digit:]]+'
> ++ awk -F '#' '{print $2}'
> + reference=1635145
> + '[' -z 1635145 ']'
> ++ clang-format --version
> + clang_format='LLVM (http://llvm.org/):
>   LLVM version 3.4.2
>   Optimized build.
>   Built Dec  7 2015 (09:37:36).
>   Default target: x86_64-redhat-linux-gnu
>   Host CPU: x86-64'

This is a pretty old version of clang. Maybe this is the problem?

Yes. That's what I suspected too. Trying to get repos for the upgrade.

But, what's surprising is that script exits.

What is the return code of clang-format? If it is non-zero then script will silently exit because that is what

it is told to do.

`#!/bin/sh -e' means exit on error.

You are right :).

 [rgowdapp@rgowdapp glusterfs]$ clang-format --version ; echo $?
LLVM (http://llvm.org/):
  LLVM version 3.4.2
  Optimized build.
  Built Dec  7 2015 (09:37:36).
  Default target: x86_64-redhat-linux-gnu
  Host CPU: x86-64
1

Wonder why clang-format --version has to return non-zero return code though.

-sac

_______________________________________________
Gluster-devel mailing list
Gluster-devel@xxxxxxxxxxx
https://lists.gluster.org/mailman/listinfo/gluster-devel