On Sat, Mar 3, 2018 at 4:25 AM, Kaleb S. KEITHLEY <kkeithle@xxxxxxxxxx> wrote: > On 03/02/2018 04:24 AM, Kaushal M wrote: >> [snip] >> I was able to create libglusterfsd, with just the pmap_signout nad >> autoscale functions. >> Turned out to be easy enough to do in the end. >> I've pushed a patch for review [1] on master. >> >> I've also opened new bugs to track the fixes for master[2] and >> release-4.0[3]. They have been made blockers to the glusterfs-4.0.0 >> tracker bug [4]. > > I really don't like creating this libglusterfsd.so with just two > functions to get around this. It feels like a quick-and-dirty hack. > (There's never time to do it right, but there's always time to do it > over. Except there isn't.) > > I've posted a change at https://review.gluster.org/19664 that moves > those two functions to libgfrpc.so. It works on my f28/rawhide box and > the various centos and fedora smoke test boxes. No tricky linker flags, > or anything else, required. Regression is running now. > > (And truth be told I'd like to also move glusterfs_mgmt_pmap_signin() > into libgfrpc.so too. Just for (foolish) consistency/symmetry.) Moving a specific RPC client implementation into RPC lib doesn't seem so right to me. But otherwise, this change is okay with me. > >> >> Shyam, >> To backport the fix from master to release-4.0, also requires >> backporting one more change [5]. >> Would you be okay with backporting that as well, in a single patch? >> >> [1]: https://review.gluster.org/19657 >> [2]: https://bugzilla.redhat.com/show_bug.cgi?id=1550895 >> [3]: https://bugzilla.redhat.com/show_bug.cgi?id=1550894 >> [4]: https://bugzilla.redhat.com/show_bug.cgi?id=1539842 >> [5]: https://review.gluster.org/19337 >> >>>> >>>>> >>>>>> >>>>>>> >>>>>>> -- >>>>>>> >>>>>>> Kaleb >>>> _______________________________________________ >>>> Gluster-devel mailing list >>>> Gluster-devel@xxxxxxxxxxx >>>> http://lists.gluster.org/mailman/listinfo/gluster-devel >>> >>> >>> >>> >>> -- >>> Milind >>> >> _______________________________________________ >> Gluster-devel mailing list >> Gluster-devel@xxxxxxxxxxx >> http://lists.gluster.org/mailman/listinfo/gluster-devel >> > _______________________________________________ Gluster-devel mailing list Gluster-devel@xxxxxxxxxxx http://lists.gluster.org/mailman/listinfo/gluster-devel
